envd icon indicating copy to clipboard operation
envd copied to clipboard

feat(lang): Support 0.0.0.0 to expose services

Open gaocegege opened this issue 3 years ago โ€ข 8 comments

Description

Ref https://github.com/tensorchord/envd/discussions/922


Message from the maintainers:

Love this enhancement proposal? Give it a ๐Ÿ‘. We prioritise the proposals with the most ๐Ÿ‘.

gaocegege avatar Sep 19 '22 12:09 gaocegege

Does this require any docker port exposure setting?

VoVAllen avatar Sep 19 '22 12:09 VoVAllen

I am not sure if you use WSL or macOS.

gaocegege avatar Sep 19 '22 12:09 gaocegege

It's Linux,I used ZeroTier to comibine a virtual local near Net and ZeroTier will allocate a virtual IP address for each host in this network.

So in virtual local near network I couldn't use locahost:port to access service ,I must use Virtual IP:port to access this docker service.

for example: This is my real local near network IP adress

eno1      Link encap:Ethernet  
          inet addr:172.16.41.35

This is my virtual local near network IP adress in the same computer

ztuwyrenjc Link encap:Ethernet  
          inet addr:10.10.10.35 

Of course I can use 172.16.41.35:port to access service in real local near network, But I couldn't use service in 10.*.*.* virtual local near network if not exposured 0.0.0.0.

xtj2020 avatar Sep 19 '22 15:09 xtj2020

I am not sure if you use WSL or macOS.

Not WSL,just a Linux(ubuntu).

xtj2020 avatar Sep 19 '22 15:09 xtj2020

Gotcha, thanks for your reply.

gaocegege avatar Sep 20 '22 03:09 gaocegege

Maybe we should support all local interface ip address. Let me check network part of docker?

aseaday avatar Sep 21 '22 13:09 aseaday

Sure, thanks!

gaocegege avatar Sep 21 '22 13:09 gaocegege

/assign @aseaday

aseaday avatar Sep 22 '22 12:09 aseaday

Hi Nullday, Are you still on the issue?

/cc @aseaday

gaocegege avatar Oct 07 '22 12:10 gaocegege

Hi Nullday, Are you still on the issue?

/cc @aseaday

sorry for late. I just returned home last night and will begin coding today.

aseaday avatar Oct 08 '22 02:10 aseaday

Seems that you have a nice vocation.

Sure, thanks.

gaocegege avatar Oct 08 '22 02:10 gaocegege

https://github.com/tensorchord/envd/pull/1128

aseaday avatar Nov 08 '22 02:11 aseaday