envd
envd copied to clipboard
feat(build): detect if the current environment is running before building
Description
Currently, the logic is: build -> check if the same container is running -> remind the user to use --force or manually clean it.
We should make it to: detect the current environment -> remind the user if it's running -> build
Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
If no one else, please assign it to me :-).
If no one else, please assign it to me :-).
/assign @Belyenochi
Thanks!
And, ask us if there is any question about this feature.
Here is the discord invitation link: https://discord.gg/KqswhpVgdU
Hi @Belyenochi
Are you still working on the issue?
Hi @Belyenochi
Are you still working on the issue?
Sorry for not updating this issue, I will try to submit the PR this week.
@gaocegege , hi gaocegege, I have two not so sure about the implementation of this problem
- Whether the original mirroring logic of rebuilding the image through --force needs to be retained, I understand that it may be necessary
- When reminding the user that the same container is running, whether the user needs to use a judgment like yes or no to allow or block the build or is it just a reminder and the default result is the same as the original --force logic
@kemingy Could you please help answer the questions?
1. Whether the original mirroring logic of rebuilding the image through --force needs to be retained, I understand that it may be necessary
Yes. We should keep the --force.
2. When reminding the user that the same container is running, whether the user needs to use a judgment like yes or no to allow or block the build or is it just a reminder and the default result is the same as the original --force logic
I think a reminder should be easy to implement.
1. Whether the original mirroring logic of rebuilding the image through --force needs to be retained, I understand that it may be necessaryYes. We should keep the
--force.2. When reminding the user that the same container is running, whether the user needs to use a judgment like yes or no to allow or block the build or is it just a reminder and the default result is the same as the original --force logicI think a reminder should be easy to implement.
thanks @kemingy @gaocegege :-).