envd icon indicating copy to clipboard operation
envd copied to clipboard

feat(build): detect if the current environment is running before building

Open kemingy opened this issue 3 years ago • 3 comments

Description

Currently, the logic is: build -> check if the same container is running -> remind the user to use --force or manually clean it.

We should make it to: detect the current environment -> remind the user if it's running -> build


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

kemingy avatar Sep 15 '22 10:09 kemingy

If no one else, please assign it to me :-).

Belyenochi avatar Sep 19 '22 08:09 Belyenochi

If no one else, please assign it to me :-).

/assign @Belyenochi

kemingy avatar Sep 19 '22 08:09 kemingy

Thanks!

And, ask us if there is any question about this feature.

Here is the discord invitation link: https://discord.gg/KqswhpVgdU

gaocegege avatar Sep 19 '22 08:09 gaocegege

Hi @Belyenochi

Are you still working on the issue?

gaocegege avatar Oct 07 '22 12:10 gaocegege

Hi @Belyenochi

Are you still working on the issue?

Sorry for not updating this issue, I will try to submit the PR this week.

Belyenochi avatar Oct 07 '22 17:10 Belyenochi

@gaocegege , hi gaocegege, I have two not so sure about the implementation of this problem

  1. Whether the original mirroring logic of rebuilding the image through --force needs to be retained, I understand that it may be necessary
  2. When reminding the user that the same container is running, whether the user needs to use a judgment like yes or no to allow or block the build or is it just a reminder and the default result is the same as the original --force logic

Belyenochi avatar Oct 08 '22 13:10 Belyenochi

@kemingy Could you please help answer the questions?

gaocegege avatar Oct 08 '22 13:10 gaocegege

1. Whether the original mirroring logic of rebuilding the image through --force needs to be retained, I understand that it may be necessary

Yes. We should keep the --force.

2. When reminding the user that the same container is running, whether the user needs to use a judgment like yes or no to allow or block the build or is it just a reminder and the default result is the same as the original --force logic

I think a reminder should be easy to implement.

kemingy avatar Oct 08 '22 13:10 kemingy

1. Whether the original mirroring logic of rebuilding the image through --force needs to be retained, I understand that it may be necessary

Yes. We should keep the --force.

2. When reminding the user that the same container is running, whether the user needs to use a judgment like yes or no to allow or block the build or is it just a reminder and the default result is the same as the original --force logic

I think a reminder should be easy to implement.

thanks @kemingy @gaocegege :-).

Belyenochi avatar Oct 08 '22 13:10 Belyenochi