envd icon indicating copy to clipboard operation
envd copied to clipboard

Published 20 hours ago • verified publisher icon tensorchord

feat: Support conda/pip requirement file

Open VoVAllen opened this issue 3 years ago • 4 comments

Description

Support pip install using requirement.txt and conda install using env.yaml(link)

VoVAllen avatar Jun 14 '22 08:06 VoVAllen

SGTM. I think we should recommend users write deps in build.envd, but we should not be extreme. We should support requirements.txt.

Users also expect that we can support this.

gaocegege avatar Jun 14 '22 08:06 gaocegege

  • [x] Support requirements.txt
  • [ ] Support conda env.yaml

gaocegege avatar Jun 20 '22 00:06 gaocegege

/assign

gaocegege avatar Jun 22 '22 01:06 gaocegege

The syntax of requirement.txt is complex (link). However current implementation can cover most common usages I believe.

One question:

--find-links https://download.pytorch.org/whl/torch_stable.html
torch==1.9.0+cu102
...

For example in dgl usage, will --find-links https://download.pytorch.org/whl/torch_stable.html be considered as a package when listing the dependency?

Yep, I think so. We just ignore comment. And every line starts without # will be considered to be a dependency.

Maybe we should mount the file into the build process, and use the file directly to install dependencies.

Originally posted by @gaocegege in https://github.com/tensorchord/envd/issues/484#issuecomment-1162705326

gaocegege avatar Jun 22 '22 06:06 gaocegege

  • [x] Support requirements.txt

    • [ ] Support conda env.yaml
  • conda env.yaml is supported in #674, should we close this issue?

kemingy avatar Aug 12 '22 06:08 kemingy