Honza Bittner

Results 125 comments of Honza Bittner

Note you don't have to create fields in the nested class and init them in constructor. You can convert static fields to getters, add a const constructor and you get...

I finished implementation of this, will add PR soon. :)

@lrhn i have it working when inner is not if-case. It's a good point that I should also check whether the inner is if-case and if so, don't assist. I...

You are right, I will update the implementation according to what you say. :)

This have been merged in https://dart-review.googlesource.com/c/sdk/+/390632, can you @FMorschel please close this issue? :)

@FMorschel can I ask you why do you allow wrapping with Expanded when parent is not a widget, and not just for Flex parents? ![image](https://github.com/user-attachments/assets/13b3c9a2-47a0-4275-abad-2ad1a9ac5444)

Do you plan to add assist to add a Flexible as well, as suggested in issue description?

@FMorschel regarding the Expanded assist on widget without parent, I really think that in practice it's always safer and more clear to do: ```dart Column( children: [ Expanded( child: MyCustomWidget(),...

I also reproduce this when I run tests locally. I only see Test starting... and nothing else.

For unit tests I would say it should not matter which first even you are adding to a bloc. After all, you should treat it as adding whichever event at...