rails-assets icon indicating copy to clipboard operation
rails-assets copied to clipboard

Published 20 hours ago • verified publisher icon tenex

Consistent with node-semver

Open milk1000cc opened this issue 8 years ago • 2 comments

This PR adds test cases and edge case handling to the Build::Utils#fix_version_string method when version string is like >1.4.x or <=1.4.x in source Bower packages.

Please see also #263.

milk1000cc avatar Aug 20 '16 08:08 milk1000cc

Great work, and thanks for the thorough test cases! I had a few comments. Going to look into the Travis CI failures now.

joshjordan avatar Aug 20 '16 12:08 joshjordan

I really doubt this change is what's breaking that integration test. I won't consider that blocking for this PR.

joshjordan avatar Aug 20 '16 12:08 joshjordan