tendomart

Results 46 comments of tendomart

What is this PR for ? Meanwhile you want to work on this 1. As a rule of the thumb always provide Title and link to the Ticket. 2. Remove...

Did you act upon all the comments ? any way look at this. https://wiki.openmrs.org/display/docs/Pull+Request+Tips On Wed, Jul 6, 2022 at 3:23 PM mumbereh ***@***.***> wrote: > ***@***.**** commented on this...

@jnsereko do you think it was necessary to Test the methods which you introduced . That's part of the Reason why coveralls is catching the changes.

Thanks @jnsereko for the additions , may be few things worth noting 1.Heading needs to be more clear 2.Your committs are 'noisy" , need to squash them , take time...

@jnsereko i know they're annoying and scary attimes but one way to always avoid them is by running a "**git pull --rebase upstream master**" at every commit ...

Thanks @jwnasambu let me also take look

@Richa-09 did you do the following before pushing -Running `mvn clean package` -Some files are missing license headers . you may always run this `mvn check-license:format` So please look into...

@LuGO0 did you look at line **32117** with this error ValidateHibernateMappingsDatabaseIT.shouldValidateHibernateMappings:74->buildSessionFactory:101 » SchemaManagement [INFO]

@sibendire what's the real purpose of this PR ?

Can you then indicate the link to the Ticket you're working on, in the Title ?