liquidity icon indicating copy to clipboard operation
liquidity copied to clipboard

feat: disable codecov on patch case that causes some wrong results

Open jaybxyz opened this issue 4 years ago • 0 comments

Summary

This issue doesn't request to remove the whole code coverage. This issue requests to remove codecov/patch part since it is unreliable and it presents weird behaviour from time to time. From our experience, it doesn't count certain lines although the lines are covered from the test codes. This results in decreasing code coverage percentage.

Proposal

Let's disable codecov patch

References

  • https://about.codecov.io/blog/announcing-line-by-line-coverage-via-github-checks/
  • https://github.com/aws/amazon-vpc-cni-k8s/pull/1226
  • https://github.com/kata-containers/tests/issues/508
  • https://github.com/tendermint/budget/issues/44

For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned

jaybxyz avatar Oct 05 '21 08:10 jaybxyz