tenacity-legacy icon indicating copy to clipboard operation
tenacity-legacy copied to clipboard

Allow dragging .aup3 file into the window

Open mc776 opened this issue 3 years ago • 3 comments

Guidelines

  • [X] I have read the guidelines.

Is your feature request related to a problem? Please describe.

Steps: Drag a project file into an existing Tenacity window. Expected: it opens the project file. Actual: a popup window nagging you to go to File -> Open instead.

Describe the solution you'd like

It would be a pretty big QoL improvement if it just opened the project file instead of telling you to do something else, only popping up a warning if there's stuff open that hasn't been saved.

Describe alternatives you've considered

I've considered just living with this and either getting annoyed every single time or remembering this one special case where I have to use the menu.

Additional context

on Debian Buster using Thunar

This issue is not a duplicate

  • [X] I have confirmed this issue isn't a duplicate.

mc776 avatar Aug 28 '21 23:08 mc776

The problem seems to lie with these lines:

https://github.com/tenacityteam/tenacity/blob/1b2c9038a4bec69ebaf07846fa007583a34c23d0/src/ProjectFileManager.cpp#L1260-L1268

Importing .aup3 files is deemed "experimental" and isn't enabled. We could either define EXPERIMENTAL_IMPORT_AUP3, or remove the check outright and have it always enabled. Needs more testing.

nbsp avatar Aug 29 '21 10:08 nbsp

Importing .aup3 files is deemed "experimental" and isn't enabled. We could either define EXPERIMENTAL_IMPORT_AUP3, or remove the check outright and have it always enabled. Needs more testing.

It doesn't make sense to me to not let people perform such a basic function and force them to perform the same exact function in a different way. Should I work on a change and pray that nothing will break? (If an edge case does and supposedly goes through our review process, we'll probably catch it before the release.)

n0toose avatar Sep 01 '21 20:09 n0toose

I've tested removing it on macOS, and it adds the dragged project's audio tracks onto the already opened project, instead of replacing it entirely.

nbsp avatar Sep 02 '21 07:09 nbsp