SC4 not working in latest build (debug), also affecting Spectrogram effects/settings

[asperkraken]

SC4 is not working in latest compile/build.

Error message: Attempting to initiate the following effect failed:

SC4

More information may be available in Help -> Diagnostics -> Show Log.

Diagnostics log: Error: Failed to load shared library 'C:\Program Files (x86)\Audacity\plug-ins\sc4_1882.dll' (error 193: %1 is not a valid Win32 application.)

Steps:

1. Select Audio.
2. Effect -> SC4.
3. Error occurs.

Built following info on BUILDING.MD with Visual Studio 19.

System info: Windows 10 Pro, x64-based PC Version 10.0.19041, Build 19041 EPSON Display Audio (embedded sound card)

Additional info: So far, other effects working OK!

[asperkraken]

In addition, this same error message also occurs when trying to update the Spectrogram settings, meaning other effects dependent on the Spectrogram will not work.

Steps:

1. Click Spectrogram on the track menu.
2. Spectrogram settings.
3. Adjust spectrogram frequencies or other settings.

Same system info as above.

[n0toose]

To clarify, this didn't happen in the previous build?

[n0toose]

• Did you install Tenacity now, without having installed Audacity prior to this?
• Did you use any previous builds of Tenacity?

[nm17]

What commit are you on? Can you see if you can use it on commit 4b8d4d30f8eb4a0d79210ecd76b46d84d6950256?

[n0toose]

@nm17 managed to establish that SC4 works on f46015d63c09fe661402201ea6154ef9e179ebf7 (Linux), which was the "latest commit" at the time when the issue was originally authored.

[asperkraken]

This must be windows-exclusive then. There is a previous pre-fork Audacity on Windows currently. Let me try uninstalling then doing a new build. My build was yesterday via instructions/programs on the current BUILDING.MD.

[asperkraken]

Did another build in CMake then compiled again in Visual Studio after uninstalling previous Audacity. Seems some plug-ins are missing now that were there when old Audacity (pre-fork) was installed. (The ones in the section with SC4 to be specific.) SC4/Spectrogram effects still not functional.

Also: apologies if i am somewhat ignorant to this process. This is my first time compiling software and i am a maker/musician by trade hoping to help with your efforts. Thank you for your patience.

[nm17]

LADSPA version of SC4 (built from source from https://github.com/swh/ladspa, the original makers of SC4) and spectrogram seems to work on latest Tenacity, probably a Windows bug.

[Kelp-Forest]

I recently built Tenacity. It defaulted to a x64 build. The Audacity web page indicates their windows installer provides a 32 bit executable(that runs on x64 windows).

The plugin auto-registration & pluginregistry.cfg bug might be present. This may make the old install's plugin seem to be the only viable plugin implementation for this plugin. Then the 32bit implementation dll is not loaded into a x64 bit process?

[Be-ing]

Can you test if #302 fixes the issue?

[3UR]

effect or command at sc4_1882.dll failed to register could not load the libary why can i not load sc4?