tenacity-legacy icon indicating copy to clipboard operation
tenacity-legacy copied to clipboard

Replace references to audacityteam.org

Open abb128 opened this issue 3 years ago • 16 comments

The README, CODE_OF_CONDUCT, and many source files contain references to audacityteam.org webpages and email addresses. These should probably be changed.

abb128 avatar Jul 07 '21 08:07 abb128

I'd suggest that we keep the Code of Conduct completely intact for the time being.

n0toose avatar Jul 07 '21 08:07 n0toose

it has refernce for audacity website,forum, wiki. Should we first make a new website, forum, wiki ?

amrithmmh avatar Jul 07 '21 13:07 amrithmmh

I had the same question!

Also, should we really remove the email addresses?

Another doubt, I saw this url (http://bugzilla.audacityteam.org), so should it be removed or edited to "http://bugzilla.tenacityteam.org"? Since I doubt, we have a bugzilla page with tenacityteam.org / tenacityaudio.org.

web3Gurung avatar Jul 07 '21 13:07 web3Gurung

Well, if people want to view the old Audacity stuff (because there were a lot of questions asked on the old forum), we should provide links just in case.

JPcode05 avatar Jul 07 '21 14:07 JPcode05

Does the occurrence of the name Audacity needs to change to Tenacity in those files?

kanissh avatar Jul 07 '21 15:07 kanissh

Could probably replace them to a tenacity url, but make the server disay a placeholder/stub page, with links to both audacity and tenacity resources. In the future the docs could be crawled or stub loads logged in some way to slowly populate with actual info

Tc-001 avatar Jul 07 '21 16:07 Tc-001

See #175

Weblate integration will make modification of the gettext strings containing this URL easy.

emabrey avatar Jul 10 '21 00:07 emabrey

Is someone working on this issue? I can change the references from "Audacity" to "Tenacity" only in the comments since I dont want to break the code. Let me know if it has to be done!

web3Gurung avatar Jul 12 '21 11:07 web3Gurung

Is someone working on this issue? I can change the references from "Audacity" to "Tenacity" only in the comments since I dont want to break the code. Let me know if it has to be done!

There isn't any PR linked to this issue, so I'm assuming no one's working on it.

nbsp avatar Jul 13 '21 14:07 nbsp

Alright, I'll work on this issue for this weekend. I'll only be working on modifying the comments which says "Audacity" to "Tenacity".

web3Gurung avatar Jul 16 '21 16:07 web3Gurung

Not sure, but seems like this commit has fixed the issue.

web3Gurung avatar Jul 16 '21 17:07 web3Gurung

@emabrey We need further feedback, what steps does a person have to make (the ones further than just replacing the parameters of XO() functions)?

n0toose avatar Aug 11 '21 14:08 n0toose

@emabrey We need further feedback, what steps does a person have to make (the ones further than just replacing the parameters of XO() functions)?

The XO functions are doing a map lookup, where what you pass is a key. If you change the key in only one place, the values (translations) won't follow. If you want to update the content of an XO you need to do so for every locale (PO files).

emabrey avatar Aug 11 '21 14:08 emabrey

No need to do this work manually, you can just change it at the XO() call and then cd into locale dir and run ./update_po_files.sh so the translation extension will handle the string matching and its mapping into the translation files.

I tried it locally and it's working, the only issue is that there's a long time the PO files weren't updated, so the diff with the previously added and changed strings is quite big.

My recommendation is to merge the latest updates from the translation files that come from weblate (so you don't get a huge conflict to solve) then right after, run the update_po_files.sh to update everything that was already changed, and then start working on changing the XO() string updates so you can get cleaner diffs.

Also, the update_po_files.sh could be added into the pull_request pipeline to prevent this accumulation of updates to be made to the PO files.

humrochagf avatar Aug 21 '21 22:08 humrochagf

@humrochagf Thank you so much for looking into this for us, you really saved us from a lot of trouble and hesitation here.

n0toose avatar Aug 22 '21 10:08 n0toose

no problem, glad to be able to help 😁

humrochagf avatar Aug 22 '21 13:08 humrochagf