pyTenable icon indicating copy to clipboard operation
pyTenable copied to clipboard

Task/in 581 v3 standardization

Open alpesh-te opened this issue 3 years ago • 2 comments

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Test A
  • [ ] Test B

Test Configuration:

  • Python Version(s) Tested:
  • Tenable.sc version (if necessary):

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

alpesh-te avatar Mar 07 '22 06:03 alpesh-te

⚠️ GitGuardian has uncovered 14 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret c9233daaeefd329366e9d90e791f244993057414 tenable/io/v3/connectors/api.py View secret
- Generic High Entropy Secret 354cb9a182c0f8a29139fba0ae48c8297f078af7 tenable/io/v3/connectors/api.py View secret
- Generic High Entropy Secret 239ceea24080dff8a5ddc20eeea0df38ea5e4a73 tenable/io/v3/connectors/api.py View secret
- Generic High Entropy Secret d1d4e8f4f1d08e24d47e1dd126bd0e8f44e4c887 tenable/io/v3/connectors/api.py View secret
- Generic High Entropy Secret 7e7a635a535a7f495d9e5476fb1e6b041ef7b38b tenable/io/v3/connectors/api.py View secret
- Generic High Entropy Secret 775cc9aef7f5f246e60669c661a119f535daf7d9 tenable/io/v3/connectors/api.py View secret
- Generic High Entropy Secret 813bcac108a3d58638bfec13cc9ae3ff55c6ccfb tenable/io/v3/connectors/api.py View secret
- Generic High Entropy Secret cc8d5d45d4c462afa19ff2f81cab719689065a07 tenable/io/v3/connectors/api.py View secret
- Generic High Entropy Secret a3c66c64df2b01bfe71fa66f222144e93133dd81 tenable/io/v3/connectors/api.py View secret
- Generic High Entropy Secret 073ccff85bc82d022041f23ff3f1e3415df7d1c3 tenable/io/v3/connectors/api.py View secret
- Generic High Entropy Secret 607492d35a13053e6e2dcaecf52f1c4e7aacf572 tenable/io/v3/connectors/api.py View secret
- Generic High Entropy Secret e786d11627d73762b44d5ad70c7f8416c0130b9f tenable/io/v3/connectors/api.py View secret
- Generic High Entropy Secret 1bdd5ac35c5f42453792d9d55ee78ba9210f40ac tenable/io/v3/connectors/api.py View secret
- Generic High Entropy Secret 618c3fa888c04ee568a912446c0ae3d303baefde tenable/io/v3/connectors/api.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Revoke and rotate the secret.

  2. If possible, rewrite git history with git commit --amend and git push --force.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Mar 07 '22 06:03 gitguardian[bot]

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 108 Security Hotspots
Code Smell A 177 Code Smells

No Coverage information No Coverage information
5.6% 5.6% Duplication

sonarqubecloud[bot] avatar Apr 19 '22 10:04 sonarqubecloud[bot]

Closing PR. Code is unmerged for 2yrs

SteveMcGrath avatar Mar 11 '24 14:03 SteveMcGrath