ui
ui copied to clipboard
Remove unnecessary button props
Description & motivation π
- Removes unnecessary
icon
prop in theButton
component - Removed unnecessary
round
prop in theMenuButton
component
Screenshots (if applicable) πΈ
Design Considerations π¨
Testing π§ͺ
How was this tested π»
- [ ] Manual testing
- [ ] E2E tests added
- [ ] Unit tests added
Steps for others to test: πΆπ½ββοΈπΆπ½ββοΈ
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?
The latest updates on your projects. Learn more about Vercel for Git βοΈ
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
holocene | β Ready (Inspect) | Visit Preview | π¬ Add feedback | May 6, 2024 7:25pm |
Do we really not ever use an icon with a button?
@stevekinney we use leadingIcon
and trailingIcon
, but looks like icon
was likely just a copy/paste from the Link
component when we replaced Link
with a <a />
in the Button
component.