ui icon indicating copy to clipboard operation
ui copied to clipboard

Remove unnecessary button props

Open laurakwhit opened this issue 9 months ago β€’ 1 comments

Description & motivation πŸ’­

  • Removes unnecessary icon prop in the Button component
  • Removed unnecessary round prop in the MenuButton component

Screenshots (if applicable) πŸ“Έ

Design Considerations 🎨

Testing πŸ§ͺ

How was this tested πŸ‘»

  • [ ] Manual testing
  • [ ] E2E tests added
  • [ ] Unit tests added

Steps for others to test: πŸšΆπŸ½β€β™‚οΈπŸšΆπŸ½β€β™€οΈ

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

laurakwhit avatar May 06 '24 18:05 laurakwhit

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
holocene βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 6, 2024 7:25pm

vercel[bot] avatar May 06 '24 18:05 vercel[bot]

Do we really not ever use an icon with a button?

stevekinney avatar May 06 '24 22:05 stevekinney

@stevekinney we use leadingIcon and trailingIcon, but looks like icon was likely just a copy/paste from the Link component when we replaced Link with a <a /> in the Button component.

laurakwhit avatar May 06 '24 22:05 laurakwhit