ui
ui copied to clipboard
Fix(query): add delimiter to the query keyword
Description & motivation π
When send out a query of custom search attribute through the options on UI, the server will return back an error if the custom search attribute include hyphen (-
), this is because hyphen is a reserved character for SQL, to send the query including such characters need to introduce delimiter backtik `
to escape.
This will address the open issue here with the minimum change only on UI.
Here is another PR for adding tests in server.
Screenshots (if applicable) πΈ
N/A
Design Considerations π¨
Testing π§ͺ
Test it though a manual test. Will open another PR in server to include the test on the attribute name with hyphen in server.
How was this tested π»
- [x] Manual testing
- [ ] E2E tests added
- [x] Unit tests added
Steps for others to test: πΆπ½ββοΈπΆπ½ββοΈ
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?
The latest updates on your projects. Learn more about Vercel for Git βοΈ
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
holocene | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Apr 22, 2024 11:28pm |