ui icon indicating copy to clipboard operation
ui copied to clipboard

Fix(query): add delimiter to the query keyword

Open alexseedkou opened this issue 10 months ago β€’ 2 comments

Description & motivation πŸ’­

When send out a query of custom search attribute through the options on UI, the server will return back an error if the custom search attribute include hyphen (-), this is because hyphen is a reserved character for SQL, to send the query including such characters need to introduce delimiter backtik ` to escape.

This will address the open issue here with the minimum change only on UI.

Here is another PR for adding tests in server.

Screenshots (if applicable) πŸ“Έ

N/A

Design Considerations 🎨

Testing πŸ§ͺ

Test it though a manual test. Will open another PR in server to include the test on the attribute name with hyphen in server.

How was this tested πŸ‘»

  • [x] Manual testing
  • [ ] E2E tests added
  • [x] Unit tests added

Steps for others to test: πŸšΆπŸ½β€β™‚οΈπŸšΆπŸ½β€β™€οΈ

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

alexseedkou avatar Apr 17 '24 23:04 alexseedkou

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
holocene βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 22, 2024 11:28pm

vercel[bot] avatar Apr 17 '24 23:04 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 17 '24 23:04 CLAassistant