ui icon indicating copy to clipboard operation
ui copied to clipboard

DT-1740 - update workflow reset UI for new reapply types in 1.24

Open rossedfort opened this issue 1 year ago • 1 comments

Description & motivation 💭

in temporal server version 1.24, a new API will be available for resetting workflows that supports reapplying Updates after the reset point, in addition to Signals. This PR makes the changes necessary to the UI support this new option. Note - the behavior is inverse, i.e. the API expects opting out of reapplies as opposed to opting in.

  • For UI running against temporal server version <1.24 - no change. Show a checkbox whether to re-apply signals after reset point, if checked send RESET_REAPPLY_TYPE_SIGNAL, if unchecked send RESET_REAPPLY_TYPE_NONE in resetReapplyType field
  • For UI running against temporal server version >=1.24 - keep checkbox for Signal, add a checkbox for Update - inverse behavior of <1.24. if only “Exclude signals” is checked - send RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL, if only “Exclude updates” is checked, send RESET_REAPPLY_EXCLUDE_TYPE_UPDATE. If both are checked send both, if none are checked, send RESET_REAPPLY_EXCLUDE_TYPE_UNSPECIFIED in resetReapplyExcludeTypes field

Screenshots (if applicable) 📸

<1.24 >=1.24
Screenshot 2024-04-17 at 2 12 52 PM Screenshot 2024-04-17 at 2 19 33 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • [ ] Manual testing
  • [ ] E2E tests added
  • [ ] Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

rossedfort avatar Apr 17 '24 21:04 rossedfort

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 4:13pm

vercel[bot] avatar Apr 17 '24 21:04 vercel[bot]

Screenshots LGTM!

dandavison avatar Sep 25 '24 22:09 dandavison