ui icon indicating copy to clipboard operation
ui copied to clipboard

Can't open workflow details on a workflow that contains special characters

Open Semior001 opened this issue 1 year ago • 1 comments

Describe the bug Opening a workflow with ID like some.domain.example.simple.ExampleService/ComplexAction(product,query,year:2024 month:4 day:10) leads to 404.

To Reproduce

  1. Start any workflow, which has an ID with special characters.
  2. Click on it in web UI.

Expected behavior Workflow details are opened.

Screenshots That's what I get now: image image

On earlier version (2.21.3) it worked perfectly fine: image(38)

Desktop (please complete the following information):

  • OS: MacOS 14.4.1
  • Browser: Firefox 124.0.2
  • Version: temporalio/ui - 2.26.0, temporalio/auto-setup - 1.22.7, temporalio/admin-tools - 1.22.7

Semior001 avatar Apr 10 '24 15:04 Semior001

I think this is the same as https://github.com/temporalio/ui/issues/1084

I added some comments there too recently

jontro avatar Apr 18 '24 17:04 jontro

We're also having this since a recent update, I've tested some names

Workflow IDs that seem to work okay:

ExampleWorkflow/1
ExampleWorkflow:1/1
ExampleWorkflow:test-1/1
ExampleWorkflow(1)
ExampleWorkflow(1.0)

Workflow IDs that provoke error 404:

ExampleWorkflow(1/0)
ExampleWorkflow(1-1)
ExampleWorkflow(1 0)
ExampleWorkflow(1:1)
ExampleWorkflow(1\1)
ExampleWorkflow(1 of 1)

nikat avatar Jun 14 '24 23:06 nikat