ui icon indicating copy to clipboard operation
ui copied to clipboard

Archival basic query interface doesn't work with S3

Open Eoncell opened this issue 2 years ago • 13 comments

image

Actual Behavior

{ "code": 3, "message": "only operation = is support for CloseTime", "details": [ ] }

Steps to Reproduce the Problem

just open archived workflows

Solution

For Google S3 we have 2 requiered fields:

  1. StartTime or CloseTime - only strict equality
  2. SearchPrecision

Please fix it

Eoncell avatar Dec 01 '22 10:12 Eoncell

I run into same issue. What makes it worse is when I go to the Advanced Search and explicitly type in my query as WorkflowTypeName='XXXX', I see that the same query gets submitted to the back end i.e. "CloseTime > "2023-04-10T12:46:55+10:00". It ignores what I just typed in the Advanced query text. Please fix this, as we need to have visibility into our archives as we set a 1 day retention period due to the volume of our execution history.

asadadekar-zuora avatar Apr 11 '23 02:04 asadadekar-zuora

afaik queries are disabled atm for S3. This might be added, however i think this is not planned yet ? @MichaelSnowden

feedmeapples avatar May 15 '23 15:05 feedmeapples

In terms of feature support, there are no plans to add inequality (>, <, <=, >=) queries for S3, only exact matches. Sorry to disappoint. I'm going to add @yiminc for visibility on this and to help prioritize. The reason it's difficult to support such queries is that we would need to build a secondary index for the objects in S3.

About this particular issue, if the Advanced Search tab is adding "CloseTime > ..." to your queries without you having entered that, then that is a bug on the frontend. @feedmeapples could you confirm whether the fix you landed for basic search to not include the inequality query was also applied to advanced search? Also, @asadadekar-zuora , what version of the server and UI are you on? The fix may not be present in your version.

MichaelSnowden avatar May 15 '23 17:05 MichaelSnowden

@MichaelSnowden I am using the temporal UI version 2.13.3

asadadekar-zuora avatar May 16 '23 07:05 asadadekar-zuora

2.13.3 doesn't have the S3 archival fix that completely disables Filters for S3 https://github.com/temporalio/ui/pull/1290 It was released with v2.14.0 https://github.com/temporalio/ui-server/releases/tag/v2.14.0

feedmeapples avatar May 22 '23 19:05 feedmeapples

i tested in ui 2.15.0 the search is disabled in archive. loading the archive takes huge time as i the number of workflows are huge as wel.. Also clicking on the archive results shows 404, as it tries to load the workflow from live system and not archive :(

Given that file store is not production ready, s3 seems to be the only production ready option, I would urge to proritize this issue, exact match is still much better than not having a search at all.

if we can make this feature similar to what it was in old web-ui, that should be a good start.

kkcmadhu avatar Jun 01 '23 16:06 kkcmadhu

@feedmeapples @mfateev @samarabbas it will be super helpful if this can be fixed. We already use s3 archieve in production, and struck as we are not able to upgrade to newer version because of the archival issue.

kkcmadhu avatar Jun 13 '23 07:06 kkcmadhu

@feedmeapples @mfateev @samarabbas This has been long pending issue, I would really appreciate, if this can be prioritized for upcoming release.

kkcmadhu avatar Jul 24 '23 05:07 kkcmadhu

I am also facing the same issue - hopefully this is fixed in the upcoming release - this is one of the important features that should work.

yashwantakash avatar Aug 02 '23 09:08 yashwantakash

Seems like web ui issue.

yiminc avatar Aug 27 '23 20:08 yiminc

@yiminc @feedmeapples , i am still sitting on old web ui , just because of this bug. It would really be awesome if we can address this at the earliest.

kkcmadhu avatar Aug 28 '23 06:08 kkcmadhu

Any plans to fix this, this is now open for quite a while now @mfateev

kkcmadhu avatar Oct 25 '23 08:10 kkcmadhu

any update on this? This is really causing us issues in prod.

kkcmadhu avatar Aug 01 '24 09:08 kkcmadhu