ui icon indicating copy to clipboard operation
ui copied to clipboard

Published 20 hours ago • verified publisher icon temporalio

Incorrect link when child workflow is started in a different namespace

Open jontro opened this issue 1 year ago • 6 comments

Describe the bug When inspecting a started child workflow a link is created to the run. This link has the same namespace as the currently selected instead of using the child workflow.

This results in a 404 and the namespace must be changed manually in the url to navigate to the correct workflow.

To Reproduce

  1. Start a child workflow in a different namespace.
  2. Navigate to the parent workflow in the web ui.
  3. Try to click any link which points to the child workflow in the Workflow tab.
  4. Get a 404 page

Expected behavior The link should point to the correct namespace

Desktop Same error in all browsers

Additional context Using latest version of ui: temporalio/ui:2.13.3

jontro avatar Apr 17 '23 14:04 jontro

https://github.com/temporalio/ui/blob/main/src/lib/components/event/event-details-row-expanded.svelte#L87 Namespace here is taken from page.params instead of the workflow execution attributes

jontro avatar Apr 17 '23 15:04 jontro

Same goes for the Parent reference: https://github.com/temporalio/ui/blob/main/src/lib/components/workflow/workflow-relationships.svelte#L45

image

jontro avatar Apr 17 '23 18:04 jontro

Fixed with:

https://github.com/temporalio/ui/pull/1350 https://github.com/temporalio/ui/pull/1354

Alex-Tideman avatar May 10 '23 13:05 Alex-Tideman

The links under Relationships seem to be fixed, but there are still invalid links under event history.

image

kristianheljas avatar Nov 30 '23 13:11 kristianheljas

In addition to the issue above that @kristianheljas reported, any running child workflow in the Relationships table also lead to a 404. Once the child workflow completes though the links are fine

aloknikhil avatar Jan 26 '24 20:01 aloknikhil

Can this please get any traction? It is very annoying bug for projects using multiple namespaces and triggering child workflows across them. Thank you!

Some potentially helpful information:

  • "Pending child workflows" component use local namespace as fallback: https://github.com/temporalio/ui/blob/1bc9fa25e872011db763288d389bf8cf5f272eb2/src/lib/components/workflow/child-workflows-table.svelte#L34
  • Server doesnt return any "namespace" from within "pendingChildren" object

tomnislav avatar Apr 18 '24 16:04 tomnislav

Any update here folks? We have a number of workflows that span namespaces. Navigation is pretty hard now with this bug

aloknikhil avatar Sep 28 '24 01:09 aloknikhil