temporal icon indicating copy to clipboard operation
temporal copied to clipboard

Send non-reachability DescribeTaskQueue requests through frontend rate limiter

Open carlydf opened this issue 1 year ago • 3 comments

What changed?

Previously, all DescribeTaskQueue requests use visibility rate limiter, which is too restrictive for non-reachability requests. Fix that by checking in the interceptor.

Why?

How did you test it?

Potential risks

Documentation

Is hotfix candidate?

carlydf avatar Sep 20 '24 21:09 carlydf

I think we need to follow up this quickly by adding caching for the stats otherwise I'm concerned about the fanout load that each describetaskqueue request will make.

ShahabT avatar Sep 24 '24 17:09 ShahabT

I think we need to follow up this quickly by adding caching for the stats otherwise I'm concerned about the fanout load that each describetaskqueue request will make.

Should @Shivs11 work on that? So far only one person has complained about the DescribeTaskQueue rate limit, so we could hold off on merging this PR until we are confident that task queue stats are protected. Mostly I wanted to make sure that the reachability rate limit would not impact users' experience of getting ApproximateBacklogCount

carlydf avatar Sep 25 '24 00:09 carlydf

I think we need to follow up this quickly by adding caching for the stats otherwise I'm concerned about the fanout load that each describetaskqueue request will make.

Should @Shivs11 work on that? So far only one person has complained about the DescribeTaskQueue rate limit, so we could hold off on merging this PR until we are confident that task queue stats are protected. Mostly I wanted to make sure that the reachability rate limit would not impact users' experience of getting ApproximateBacklogCount

Agreed, lets hold off on getting this PR in. I shall work on getting caching added for the stats

Shivs11 avatar Sep 25 '24 14:09 Shivs11