temporal icon indicating copy to clipboard operation
temporal copied to clipboard

Deprecation proposal: Block build-id as a search attribute

Open Shivs11 opened this issue 1 year ago • 0 comments

What changed?

  • Adds a log with the WARN level for Search Attributes having BuildIds set.
  • Only a log statement has been added, for now, since rejecting such requests would mean breaking changes for current customers writing them.
  • Thus, for now, we should notify them that this change is going to take place and plan in which version we deprecate moving forward, to reject such requests.

Why?

  • BuildIds is a default SA and should not be set by the customer.

How did you test it?

  • added unit tests
  • existing suite of tests

Potential risks

none, just a logging statement is being added for now.

Is hotfix candidate?

nope

Shivs11 avatar Sep 06 '24 19:09 Shivs11