temporal icon indicating copy to clipboard operation
temporal copied to clipboard

[SQL] GetWorkflowExecution() fetch RunID internally if not provided

Open gow opened this issue 1 year ago • 0 comments

What changed?

GetWorkflowExecution() methods in SQL implementations (Postgres, Mysql & Sqlite) now fetches the current runID if one is not provided.

Why?

We are making changes to persistence interface to keep storage specific implementation details behind persistence interface. This change is similar to the change we made in Cassandra (https://github.com/temporalio/temporal/pull/6399). With this change all the storage layer implementations of GetWorkflowExecution() will handle missing RunID. In the followup PRs we'll modify the application to not explicitly fetch current runID to get to a mutable state.

How did you test it?

Added unit tests + existing tests

Potential risks

Low. We need to keep an eye on temporal running on SQL storages.

Documentation

N/A

Is hotfix candidate?

No

gow avatar Aug 15 '24 00:08 gow