temporal icon indicating copy to clipboard operation
temporal copied to clipboard

Set sniff schema when elasticsearch `enableSniff` config is true

Open abbat opened this issue 1 year ago • 2 comments

What changed?

By default elasticsearch client use http schema when sniff nodes (see DefaultScheme in olivere/elastic/client.go). This change set sniff schema to first host schema in config.

Why?

If elasticsearch cluster nodes works with httpS, sniffing works incorrect because add http (not httpS) discovered nodes.

How did you test it?

Run elasticsearch cluster with httpS nodes and set enableHealthcheck config to true. Before this change you will see "http://<node>:9200 is dead" messages (due http schema).

Potential risks

Seems no risks still enableSniff is false by default and not used in config_template.yaml.

Documentation

No, enableSniff is not documented yet.

Is hotfix candidate?

No.

abbat avatar May 18 '24 17:05 abbat

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 18 '24 17:05 CLAassistant

This PR was marked as stale. Please update or close it.

github-actions[bot] avatar Mar 31 '25 00:03 github-actions[bot]