temporal icon indicating copy to clipboard operation
temporal copied to clipboard

Fix sequence diagram rendering

Open gow opened this issue 1 year ago • 3 comments

What changed?

The sequence diagram rendering in history service doc is broken. Looks like there is a redundant break tag <br> that is causing it to not render correctly.

Why?

To fix the sequence diagram rendering.

How did you test it?

Previewed the doc and verified that the diagram is rendered correctly.

Potential risks

N/A

Documentation

N/A

Is hotfix candidate?

No

gow avatar Mar 15 '24 07:03 gow

Hi @gow, I deliberately used two <br> tags there to add vertical separation between the annotation "thirty days elapses" and the event "timer fired", so that it was clear that they were two different concepts (as opposed to "the thirty day timer fired"). It's rendering correctly for me in VSCode and Chrome.

image

dandavison avatar Mar 15 '24 14:03 dandavison

Interesting. This is what I saw on Safari. I didn't verify in other browsers and assumed it's broken. Maybe something else is at play here. I'll take another look. Screenshot 2024-03-15 at 8 23 38 AM

gow avatar Mar 15 '24 15:03 gow

thanks!

oops actually I didn't see the safari screenshot you posted ..

carlydf avatar Mar 19 '24 23:03 carlydf