temporal icon indicating copy to clipboard operation
temporal copied to clipboard

Apply build ID assignment rules

Open ShahabT opened this issue 1 year ago • 0 comments

What changed?

Assigning a task to the appropriate build ID based on the versioning assignment rules.

For now, both old and new versioning data is supported, in the following manner

  • tasks for unassigned (new) workflows/activities -> first try assignment rules, if there is no matching assignment rules fallback to default version set.
  • tasks of existing versioned executions -> if the build id is part of a version set keep using the version set, otherwise, assume user intends to use the new API and use a dedicated queue for the build ID.
    • This means we no longer created "guessed" version sets for "unkown" build IDs
  • tasks of existing unversioned executions -> stays unversioned

Why?

Part of new Worker Versioning API

How did you test it?

Unit tests, functional test will come when the API for adding rules is implemented.

Potential risks

Because we no longer created "guessed" version sets for "unkown" build IDs, users of old WV API may "loose" tasks in extremely rare situations. But that is expected for the old API given its private preview stage.

Is hotfix candidate?

No.

ShahabT avatar Jan 24 '24 22:01 ShahabT