temporal icon indicating copy to clipboard operation
temporal copied to clipboard

Add support for display archived workflow on web ui from s3 archival store

Open Aoao54 opened this issue 1 year ago • 7 comments

What changed? Add index workflowRunId to s3 archival store and support query on it. Alter DescribeWorkflowExecution func to support describeArchivedWorkflowExecution.

Why? Support for display archived workflow on web ui. Up to now, for the archived workflow which has past the retention can't displayed on the web ui.

How did you test it? Add an unit test TestDescribeWorkflowExecution_ArchivedStatus . And test the feature locally by opening archived wf which has past the retention on the web ui.

Potential risks

Is hotfix candidate?

Aoao54 avatar Nov 15 '23 11:11 Aoao54

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 15 '23 11:11 CLAassistant

Got something wrong with unit test,I'll find some time to fix it.

Aoao54 avatar Nov 16 '23 01:11 Aoao54

Related issue on UI repo: https://github.com/temporalio/ui/issues/1174

jlegrone avatar Dec 18 '23 17:12 jlegrone

Why is changes required to temporal? The cli can show archived workflow executions and the web-ui supported this in the past.

jontro avatar Mar 10 '24 15:03 jontro

Hi @jontro , you can check this issues for more context.

In a word , the archived WF which has past the retention can't displayed on the web ui. Because the web ui read archived WF info from history store but it will be deleted after the retention. So there is a 404 error.

Aoao54 avatar Mar 11 '24 01:03 Aoao54

Hi @jontro , you can check this issues for more context.

In a word , the archived WF which has past the retention can't displayed on the web ui. Because the web ui read archived WF info from history store but it will be deleted after the retention. So there is a 404 error.

Yes but shouldn't that change be made in the web ui instead? The api already supports getting archived workflows.

jontro avatar Mar 11 '24 22:03 jontro

This PR was marked as stale. Please update or close it.

github-actions[bot] avatar Jul 10 '24 00:07 github-actions[bot]