temporal icon indicating copy to clipboard operation
temporal copied to clipboard

Reset should be allowed with pending childWF in current run, if current run is already closed

Open longquanzheng opened this issue 3 years ago • 4 comments

https://github.com/temporalio/temporal/blob/0c735e4969e95ff8c113fc73ed15fca1bc2999c2/service/history/ndc/workflow_resetter.go#L290

Mirror issue https://github.com/uber/cadence/issues/5030

This is because child WF could get get closed after parent closed, and parent will not receive the children close signals.

So that after parent is closed for any reasons(terminate/timeout/fail/etc), this parent is never allowed to reset to anywhere because it has a pending childWFs in its mutableState forever as "deadlock condition"

longquanzheng avatar Nov 19 '22 00:11 longquanzheng

Relates to https://github.com/temporalio/temporal/issues/705

taonic avatar Jun 06 '23 05:06 taonic

Any updates on this @yiminc?

I am also encountering that a workflow, without any pending children, cannot be reset to anything else but the first WorkflowTaskCompleted due to the WorkflowResetter encountered pending child workflows. error.

MalteHB avatar Jan 05 '24 09:01 MalteHB

Hi @yiminc , do we have any plans to address this issue? I'm also stuck on this problem.

yujiachen-y avatar Jul 18 '24 07:07 yujiachen-y