sdk-typescript icon indicating copy to clipboard operation
sdk-typescript copied to clipboard

feat(workflow): Support workflow ID conflict policy

Open antlai-temporal opened this issue 1 year ago • 5 comments

What was changed

Added workflowIdConflictPolicy to workflow start and SignalWithStart

Checklist

  1. Closes #1392
  2. How was this tested:

Added two integration tests

antlai-temporal avatar Aug 13 '24 08:08 antlai-temporal

@dandavison Thanks a lot for a careful review of the docstrings, it made a huge difference!

antlai-temporal avatar Aug 14 '24 18:08 antlai-temporal

@antlai-temporal 👋 what's standing in the way of merging? Asking since this is the last PR before we can publish the documentation.

stephanos avatar Aug 27 '24 15:08 stephanos

@antlai-temporal 👋 what's standing in the way of merging? Asking since this is the last PR before we can publish the documentation. Sorry @stephanos just saw your comment. I was waiting for @mjameswh to give me the go ahead, I don't think this will be controversial...

antlai-temporal avatar Sep 06 '24 03:09 antlai-temporal

Sorry @stephanos and @antlai-temporal for the delay. I was on FTO.

It just so happens that I was reviewing this PR tonight, and I actually do have concerns that I want to resolve before this API reaches a TS release. Please hold on just a bit longer.

mjameswh avatar Sep 06 '24 05:09 mjameswh

@mjameswh no worries; I was actually informed that the docs are only blocked on the Go SDK and are therefore unblocked now!

stephanos avatar Sep 06 '24 19:09 stephanos

👋 Is there an update here?

stephanos avatar Oct 30 '24 15:10 stephanos

@antlai-temporal is there an update here?

stephanos avatar Nov 07 '24 19:11 stephanos

I will refactor the WorkflowIdConflictPolicy enum in #1534.

Thanks @mjameswh !

antlai-temporal avatar Nov 08 '24 21:11 antlai-temporal