sdk-typescript icon indicating copy to clipboard operation
sdk-typescript copied to clipboard

Published 20 hours ago • verified publisher icon temporalio

feat(workflow): add upsert memo command

Open tharun208 opened this issue 1 year ago • 5 comments

What was changed

Implement upsertMemo command

Why?

See https://github.com/temporalio/features/issues/119

Checklist

  1. Closes #1124

  2. How was this tested: Added integration tests

  3. Any docs updates needed?

tharun208 avatar Dec 18 '23 07:12 tharun208

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 18 '23 07:12 CLAassistant

Thanks!

Overall lgtm.

Please also test deleting a memo and reading the memo from WorkflowHandle.describe, I think setting a value to null or undefined should work.

For testing, use the new style at https://github.com/temporalio/sdk-typescript/blob/main/packages/test/src/test-integration-workflows.ts

bergundy avatar Dec 18 '23 14:12 bergundy

@tharun208 Do you want to continue working on this, or should we take it on? We'd need some more tests, as pointed out by bergundy previously.

mjameswh avatar Jan 22 '24 14:01 mjameswh

Hi @mjameswh, I was on PTO but will look into this week

tharun208 avatar Jan 31 '24 11:01 tharun208

Any updates here @tharun208 ?

stevensona avatar Apr 28 '24 17:04 stevensona

Any update on this getting merged?

nhalstead avatar Jun 08 '24 20:06 nhalstead

Bump on the ETA for this? Would be happy to pitch in!

kencrim avatar Jul 16 '24 04:07 kencrim

Hi, I will work on it today

tharun208 avatar Jul 16 '24 12:07 tharun208

Hi, I will work on it today

@tharun208 Ah! I missed your message. I just fixed your PR.

mjameswh avatar Jul 16 '24 21:07 mjameswh