sdk-python icon indicating copy to clipboard operation
sdk-python copied to clipboard

Adds ruff, a drop-in replacement for black

Open rachfop opened this issue 1 year ago • 1 comments

What was changed

Added isort: skip_file in the .gitignore file, because ruff will follow isorts commands. Replaced black with ruff in the .pyproject.toml` file.

  • ran poe format && poe lint

There were a lot of changes made.

  • removed unused imports
  • removed/added white space according to pydoc style If this is too much, let me know and I close this PR and find a way later to make less changes. Looking for a quick win.

Why?

https://github.com/temporalio/sdk-python/issues/421

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

rachfop avatar Nov 09 '23 17:11 rachfop

Can you work out the CI kinks? Make sure the app lints and tests all complete properly. Can mark as draft while you work through them.

cretz avatar Nov 09 '23 17:11 cretz

Thanks @rachfop! We followed through with this in https://github.com/temporalio/sdk-python/pull/566

dandavison avatar Jul 23 '24 00:07 dandavison