sdk-php icon indicating copy to clipboard operation
sdk-php copied to clipboard

Activity pause

Open roxblnfk opened this issue 7 months ago • 1 comments

What was changed

Added ActivityPausedException that is thrown on getting paused flag from heartbeat.

Checklist

  1. Closes #588
  2. How was this tested: manually
  3. Wait RoadRunner 2025.2

roxblnfk avatar May 19 '25 18:05 roxblnfk

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2025 2:34pm

vercel[bot] avatar May 19 '25 18:05 vercel[bot]

@Sushisource do we need to add tests with unpause?

roxblnfk avatar Jul 02 '25 13:07 roxblnfk

I don't think you do, really. From SDK's perspective it's just a new activity attempt.

However, I do think we need to add some additional info to the context, since it's possible for multiple of these exceptional states to be happening, now. Ex, in Python: https://github.com/temporalio/sdk-python/blob/633b90c60580b73027053ca95becec0f37d09eeb/temporalio/activity.py#L147

Context of the whole commit here: https://github.com/temporalio/sdk-python/commit/27cc67f1c62b7c1ad058fa7ea2bee49ed061676e

Sushisource avatar Jul 02 '25 23:07 Sushisource

Added Activity::getCancellationDetails() that returns ActivityCancellationDetails DTO

roxblnfk avatar Jul 08 '25 14:07 roxblnfk