sdk-php icon indicating copy to clipboard operation
sdk-php copied to clipboard

Possibility to configure temporal test server host

Open cv65kr opened this issue 3 years ago • 3 comments

Why?

To have possibility to change default port for temporal test server. Also: Since output of RR is not visible in PHPunit sometimes it's hard to figure out where is the error. So you can switch test server to real temporal server and see in UI what's happened. Alternatively Datadog offers https://github.com/temporalio/temporalite own server which also can be use for tests purposes.

cv65kr avatar Jul 29 '22 13:07 cv65kr

Maybe it can be moved to env variable in phpunit.xml file? 🤔 Instead of hardcoding or passing around variables.

seregazhuk avatar Aug 02 '22 17:08 seregazhuk

That was my original idea, but I was a bit confused why it was hard coded on beginning 🤔 Anyway updated

cv65kr avatar Aug 03 '22 05:08 cv65kr

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 10 '22 12:08 CLAassistant

@seregazhuk I think I found issue with CI, let's try with CI

cv65kr avatar Aug 17 '22 20:08 cv65kr