sdk-go icon indicating copy to clipboard operation
sdk-go copied to clipboard

Possibility to deprecate attribute `Control`

Open wxing1292 opened this issue 4 years ago • 5 comments

Is go SDK still using Control for the following cases?

can we deprecate above 2 attributes?

wxing1292 avatar Dec 02 '21 23:12 wxing1292

Yes, they are used at https://github.com/temporalio/sdk-go/blob/v1.11.1/internal/internal_event_handlers.go#L869 and https://github.com/temporalio/sdk-go/blob/v1.11.1/internal/internal_event_handlers.go#L1390 respectively.

We can look into deprecating and/or using alternative approaches if necessary. Can you explain the reasoning for deprecation?

cretz avatar Dec 03 '21 14:12 cretz

@wxing1292 - Bump

cretz avatar Dec 16 '21 21:12 cretz

previously the control (cadence SDK) contains the auto-incremented ID for in mem state machine

  • request cancel external workflow
  • signal external workflow
  • child workflow?
  • activity
  • timer

i am checking if it is easy to deprecate this control variable since it is easy to break

wxing1292 avatar Dec 16 '21 21:12 wxing1292

I am afraid it is not easy to deprecate since it is in active use and could affect compatibility if changed.

cretz avatar Dec 16 '21 21:12 cretz

Marking this as something for the next-gen SDK.

cretz avatar Dec 16 '21 21:12 cretz