sdk-go icon indicating copy to clipboard operation
sdk-go copied to clipboard

Update `go-grpc-middleware` to v2

Open SpencerC opened this issue 1 year ago • 5 comments

What was changed

Updated go-grpc-middleware to v2 and fixed broken APIs.

Why?

Outdated dependency.

SpencerC avatar Jan 23 '24 17:01 SpencerC

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 23 '24 17:01 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 23 '24 17:01 CLAassistant

The linked issue refers to grpc_gateway not go-grpc-middleware so I am not sure how this PR is related

Quinn-With-Two-Ns avatar Jan 23 '24 17:01 Quinn-With-Two-Ns

@Quinn-With-Two-Ns, my mistake, it isn't. :smiling_face_with_tear:

SpencerC avatar Jan 23 '24 18:01 SpencerC

@Quinn-With-Two-Ns can you review this PR please?

tranngoclam avatar Jul 13 '24 04:07 tranngoclam