sdk-core icon indicating copy to clipboard operation
sdk-core copied to clipboard

[Feature Request] Support new failure field in query responses

Open Sushisource opened this issue 11 months ago • 3 comments

Is your feature request related to a problem? Please describe.

The query response proto(s) now support sending a Failure rather than just an error message. Support this. Code contains TODOs with this issue number.

Sushisource avatar Jan 23 '25 23:01 Sushisource

Can you give more information about this feature request? I'd like to work on it What proto message is this?

sainad2222 avatar Jan 31 '25 12:01 sainad2222

@sainad2222 Thanks for your interest. The issue mentions you can search for this number, that leads you to two places the client needs to be changed and that's mostly it. This function will need to be changed to return the whole failure instead of just the string message. The error message field will need to continue to be set to support older servers.

Some tests will need to be added as well to verify the complete failure makes it to the server.

Sushisource avatar Feb 04 '25 17:02 Sushisource

If I understood correctly wherever we are sending just message as String in that function, now we also needs to send Failure proto like this(just message field)?

Failure{
    message: err.message
}

sainad2222 avatar Feb 04 '25 19:02 sainad2222