sdk-core icon indicating copy to clipboard operation
sdk-core copied to clipboard

Rename WorkflowExecutionUpdateRequested

Open stephanos opened this issue 1 year ago • 2 comments
trafficstars

What was changed

Renamed WorkflowExecutionUpdateRequested to WorkflowExecutionUpdateAdmitted to match latest API change.

The protos were only updated to match the API rename change as pulling in all changes resulted in compilation errors.

The PR to introduce these was https://github.com/temporalio/sdk-core/pull/677/files

Why?

Follow-up to https://github.com/temporalio/api/pull/387

stephanos avatar Apr 03 '24 16:04 stephanos

Are these API changes released?

Quinn-With-Two-Ns avatar Apr 03 '24 17:04 Quinn-With-Two-Ns

@Quinn-With-Two-Ns yes, see https://github.com/temporalio/api-go/releases/tag/v1.32.0

stephanos avatar Apr 15 '24 15:04 stephanos

Forgot to merge this 🤦 Has been addressed in other PRs (eg https://github.com/temporalio/sdk-core/pull/700/files) already. No need to merge anymore.

stephanos avatar Sep 17 '24 05:09 stephanos