sdk-core icon indicating copy to clipboard operation
sdk-core copied to clipboard

[Feature Request] More efficient large payload handling

Open Sushisource opened this issue 4 years ago • 1 comments

Right now it's possible (in particular for local activities, which is why I'm writing this) to clone large payloads inside events during history lookahead (and possibly also application).

Ideally that would be avoided as it could cause substantial overhead during replay. Create a bench test to verify and then improve.

Possible fixes:

  • Rc/Arc Payload(s) types - also would require a custom HistoryEvent version (maybe prost annotation?)
  • Never clone HistoryEvents, always use refs

This might require https://github.com/temporalio/sdk-core/issues/180 to be done, as it probably allows using Rc more freely.

Sushisource avatar Nov 17 '21 00:11 Sushisource

At least partially fixed in https://github.com/temporalio/sdk-core/pull/279

Sushisource avatar Feb 28 '22 22:02 Sushisource