sdk-core icon indicating copy to clipboard operation
sdk-core copied to clipboard

[Feature Request] Report extra commands as nondeterminism errors sooner

Open Sushisource opened this issue 2 years ago • 1 comments

Assuming this is actually something that makes sense to do and can be done (following up on that):

When replaying, if a WFT application results in commands being produced which do not have a corresponding command-event in history following that WFT's completion event, we should blow up with a nondeterminism error along the lines of "extra commands produced".

As it stands that should happen eventually in that some command event will be applied which doesn't match the extra command, but it doesn't happen as soon as it could, which harms debugability.

Ideally, we should blow up as soon as we finish applying a WFT (through WFT completed + commands in that WFT) if we notice there are extra commands lying around that were not matched. My initial attempts to do this though resulted in a bunch of spurious errors. (Note to self: Saved a shelf with my attempts)

Sushisource avatar Nov 09 '21 22:11 Sushisource

Note that the inverse could also make sense (if history has some command that was not produced in the workflow task, then fail)

Sushisource avatar Feb 23 '22 21:02 Sushisource