samples-python icon indicating copy to clipboard operation
samples-python copied to clipboard

[Bug] Remove/move set_tracing_disabled from inside OpenAI sample workflows

Open cretz opened this issue 6 months ago • 3 comments

Describe the bug

Two workflows at https://github.com/temporalio/samples-python/tree/main/openai_agents/model_providers/workflows encourage users to call the global set_tracing_disabled inside the workflow. Should either remove altogether or move to the _worker.py file instead.

cretz avatar Sep 08 '25 15:09 cretz

Let's move it to the worker.py to keep as much fidelity as possible with the OpenAI Agents SDK Examples. We can also highlight / comment on why it is there.

jssmith avatar Sep 08 '25 17:09 jssmith

For bonus points, we could go one further and update the OpenAI plugin to have the sandbox consider all such side-effecting calls as illegal.

cretz avatar Sep 08 '25 19:09 cretz

Describe the bug

Two workflows at https://github.com/temporalio/samples-python/tree/main/openai_agents/model_providers/workflows encourage users to call the global set_tracing_disabled inside the workflow. Should either remove altogether or move to the _worker.py file instead.

Describe the bug

Two workflows at https://github.com/temporalio/samples-python/tree/main/openai_agents/model_providers/workflows encourage users to call the global set_tracing_disabled inside the workflow. Should either remove altogether or move to the _worker.py file instead.

reeflose88-netizen avatar Oct 25 '25 02:10 reeflose88-netizen