samples-go icon indicating copy to clipboard operation
samples-go copied to clipboard

Add test for NonRetryableErrors

Open rylandg opened this issue 3 years ago • 1 comments

As of today there are no integration level tests for NewNonRetryableApplicationError. This is a problem because we reference the feature in our docs and its a bit hard to find any info on it. '

We do have a test which specifies non-retryable errors: https://github.com/temporalio/sdk-go/blob/06e1ca56f3a286e072a048576b5e372ea0a497d6/internal/internal_workflow_testsuite_test.go#L2456

But seems to do so incorrectly:

https://github.com/temporalio/sdk-go/blob/06e1ca56f3a286e072a048576b5e372ea0a497d6/internal/internal_workflow_testsuite_test.go#L2359

rylandg avatar Mar 07 '21 23:03 rylandg

I think this was filed on the wrong repo?

robholland avatar Mar 15 '22 10:03 robholland