samples-go icon indicating copy to clipboard operation
samples-go copied to clipboard

add errgroup sample

Open jackielii opened this issue 3 years ago • 2 comments

What was changed

add errgroup sample

Why?

errgroup synchronise cancellation is a common pattern.

Checklist

  1. How was this tested:

go run errgroup/errgroup.go

  1. Any docs updates needed?

No other updates needed. Added README.md

jackielii avatar May 10 '22 08:05 jackielii

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 10 '22 08:05 CLAassistant

Thanks! Can I make a few requests? Firstly, can you split into the starter and worker CLI off as we do in other samples? Second, can you update the root repo README to point to this sample? Finally, can you add a test? Thanks!

cretz avatar May 16 '22 15:05 cretz