proposals icon indicating copy to clipboard operation
proposals copied to clipboard

tctl: Add spinner to long running commands [p2]

Open feedmeapples opened this issue 3 years ago • 5 comments

  • Origin issue:

Summary

Adds spinner and progress bar for potentially long running commands. Makes tctl feel more responsive

Basic example

Motivation

Some commands may take long time until they will show output or an error (typically context timeout). This makes tctl feel unresponsive and slow. Proposal addresses these issues adding responsiveness

Detailed design

in doc

Drawbacks

Alternatives

Adoption strategy

not a breaking change

How we teach this

feedmeapples avatar Jun 16 '21 00:06 feedmeapples

We should make sure that indicators are only shown when output is a TTY because it will conflict with piping.

bergundy avatar Jun 17 '21 00:06 bergundy

It'd be nice to have a flag to dictate this as well.

robzienert avatar Jun 17 '21 01:06 robzienert

We should make sure that indicators are only shown when output is a TTY because it will conflict with piping.

yup, this is covered

feedmeapples avatar Jun 17 '21 05:06 feedmeapples

It'd be nice to have a flag to dictate this as well.

Updated the terminology to "spinner" and "progress bar", specified --no-progress in the doc (similar to npm --no-progress)

feedmeapples avatar Jun 17 '21 05:06 feedmeapples

this proposal is on hold rn, focused on implementing higher priority proposals and releasing tctl. Afterwards planning to finish and implement this proposal

feedmeapples avatar Jul 16 '21 22:07 feedmeapples

This is outdated. Closing due to lack of motivation.

bergundy avatar May 07 '24 18:05 bergundy