helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[Feature Request] integrate with kube-prometheus-stack

Open ImSingee opened this issue 10 months ago • 2 comments

Currently, the chart only supports installing its own prometheus and grafana.

However, in most cases, user has already set up the kube-prometheus-stack.

Feature Request: add a way to just utilize existing promtheus and grafana for monitoring

ImSingee avatar Mar 19 '25 05:03 ImSingee

Hello

I believe that you mean is this: https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack

I've my own monitoring stack:

  • prometheus or opentelemetry, doing service discovery based on annotations https://github.com/temporalio/helm-charts/blob/main/charts/temporal/templates/server-deployment.yaml#L26-L28
  • grafana, with temporal dashboard https://github.com/temporalio/dashboards/tree/master

So, having prometheus + grafana as a dependency in Chart.yaml, would only be usefull to test the chart locally. @robholland are these dependencies really needed in Chart.yaml? (of course they can be disabed in values.yaml)

luiscosta18 avatar Mar 25 '25 19:03 luiscosta18

Done in https://github.com/temporalio/helm-charts/pull/534 and https://github.com/temporalio/helm-charts/pull/526, but these are on the v1 branch. There is still more work to do there before these will be released.

robholland avatar Mar 27 '25 09:03 robholland