helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Unexpected behavior when using arbitrary elasticsearch visibility index

Open phuongdnguyen opened this issue 1 year ago • 2 comments

Expected Behavior

Current temporal helm chart expose elasticsearch visibility index name as a configurable option, see. Expected behavior for user is they can specify arbitrary index name.

Actual Behavior

This setting only works if visibility index starts with temporal_visibility_v1_dev, as shown here

Steps to Reproduce the Problem

  1. Use random visibilityIndex name in elasticsearch block when starting temporal server
  2. Start the temporal server along with its dependencies
  3. Start some random workflow
  4. Temporal ui workflow list page is empty

Specifications

  • Version: v1.25.1
  • Platform: darwin arm64

phuongdnguyen avatar Nov 05 '24 05:11 phuongdnguyen

Looks like the code wants temporal_visibility_v1*. This is by design, we should enforce this in the helm chart. There's a way to validate chart values as shown here: https://www.arthurkoziel.com/validate-helm-chart-values-with-json-schemas/.

bergundy avatar Nov 14 '24 23:11 bergundy

Yes i also think that the helm chart is the go to place for deployment value validation. This will resolve this https://github.com/temporalio/temporal/issues/5475 too, i think.

phuongdnguyen avatar Nov 15 '24 10:11 phuongdnguyen