helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[Issue 523] Fix logic for createDatabase.enabled variable

Open ogusak opened this issue 1 year ago • 3 comments

What was changed

Fixed logic flow for .Values.schema.createDatabase.enabled to allow creating databases if they are not provisioned beforehand.

Why?

See bug described in https://github.com/temporalio/helm-charts/issues/523

Checklist

  1. Closes 523

  2. How was this tested: helm template . -f values/values.postgresql.yaml --debug > test.yaml and inspecting content of the resulting manifest. Tested for

  • .Values.schema.createDatabase.enabled=true
  • .Values.schema.createDatabase.enabled=false
  1. Any docs updates needed? N/A

ogusak avatar Jul 03 '24 23:07 ogusak

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 04 '24 00:07 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 04 '24 00:07 CLAassistant

Should be fixed by #522, please test this and let me know.

robholland avatar Jul 04 '24 08:07 robholland

Please let me know if #522 does not fix this for you, I'll re-open.

robholland avatar Jul 05 '24 15:07 robholland

Tested just now and can see create-default-store and create-visibility-store init containers are rendered. Thank you @robholland !

ogusak avatar Jul 05 '24 17:07 ogusak