helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard
verified publisher icon temporalio

feat: Enable LivenessProbe for workers

Open gracco opened this issue 3 years ago • 2 comments

What was changed

This pull request removes the loop to not add livenessProbe for workers

Why?

Every service should have a livenessProbe, in case of failure the kubelet be capable to restart the pod.

Checklist

  1. Closes #298

  2. How was this tested: It was applied via helm in our cluster.

  3. Any docs updates needed? No

gracco avatar Jun 08 '22 18:06 gracco

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 08 '22 18:06 CLAassistant

@gracco you might want to check to the reasons why that conditional has been put in place before wiring this change. See here https://github.com/temporalio/helm-charts/pull/74#issue-701518539

mazzy89 avatar Jun 09 '22 14:06 mazzy89