helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[Feature Request] Allow specifying TLS configuration

Open sd-hypredge opened this issue 2 years ago • 5 comments

Is your feature request related to a problem? Please describe.

The ability to specify and configure TLS options is documented (https://docs.temporal.io/docs/server/configuration/#tls) but not implemented in the charts

Describe the solution you'd like

Ability to configure and MTLS options in values.yaml

Additional context

sd-hypredge avatar May 09 '22 03:05 sd-hypredge

The capability is just an incremental change over existing chart, hence I have not submitted a formal proposal. I have an implementation that follows the outline of the mechanics described in the documentation (https://docs.temporal.io/docs/server/configuration/#tls) , and serves the use case . I will contribute a PR if the feature request is prioritized for implementation

sd-hypredge avatar May 10 '22 20:05 sd-hypredge

Hi, I made a PR a long time ago but closed because they wanted to revamp the project ... https://github.com/temporalio/helm-charts/pull/162

(I'm still using it for myself and our organization because TLS is a prerequisite)

lerminou avatar Jun 21 '22 08:06 lerminou

@lerminou Coming accross the exact same issue at the moment and need to setup mTLS for the frontend SDK as a prerequisite - Will take a look at your PR 👍

gthomson31 avatar Jun 21 '22 10:06 gthomson31

@underrun does it make sense to wait for the new helm charts, is it likely that this feature will be added to the existing helm charts, or should we in the meantime customize the existing chart ourselves locally (similar to PR https://github.com/temporalio/helm-charts/pull/162), if we need the feature? Thanks for any feedback :)

p4p4 avatar Jul 12 '22 13:07 p4p4

What is the chances the original proposed PR can be re-opened? This proposal is now closed, which leads me to believe nobody internal is working on it. https://github.com/temporalio/proposals/issues/42

joshbranham avatar Sep 20 '23 18:09 joshbranham