cli icon indicating copy to clipboard operation
cli copied to clipboard

Remove Makefile

Open cretz opened this issue 1 year ago • 4 comments

What was changed

To be consistent with other SDK repos, remove Makefile that was added in an unrelated PR at #561. May be reintroduced, but should at least get wider consensus and be called in CI to confirm it even works.

cretz avatar Sep 13 '24 13:09 cretz

I have not forgotten about this.

If we remove it, I would like to replace it with something platform-independent and standardized (as much as possible in the Go ecosystem anyway) that accomplishes the same goal. Otherwise I think having it (and maybe adding a script for Windows folks) is better than nothing.

josh-berry avatar Sep 23 '24 14:09 josh-berry

If we remove it, I would like to replace it with something platform-independent and standardized (as much as possible in the Go ecosystem anyway) that accomplishes the same goal

This exists and is called go build and go run and was the accepted cross-platform method of working with the CLI until this Makefile got added in an unrelated PR sans discussion (compared to this PR which is getting discussion).

cretz avatar Sep 23 '24 15:09 cretz

This exists and is called go build and go run

Dan and I have both explained why this is not the same thing as the Makefile--you might want to review that Slack discussion. If you need a pointer to it, poke me separately and I'll find it again for you.

josh-berry avatar Sep 23 '24 15:09 josh-berry

:+1: Definitely understood it's not the same thing as a Makefile, on purpose, it's better, consistent, more cross-platform, etc. There was a CLI way, this secretly changed, and looks like it's not going back.

cretz avatar Sep 23 '24 15:09 cretz