cli icon indicating copy to clipboard operation
cli copied to clipboard
verified publisher icon temporalio

Fix register search attributes when starting server

Open rodrigozhou opened this issue 1 year ago • 3 comments

What was changed

Fix register search attributes when starting server

Why?

Currently, search attributes are registered after the server is ready, which can cause race condition with other processes waiting for the server to become ready too. This PR fixes this by registering the search attributes together with the namespaces.

Address https://github.com/temporalio/temporal/issues/6195

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

rodrigozhou avatar Sep 04 '24 00:09 rodrigozhou

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 04 '24 00:09 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 04 '24 00:09 CLAassistant

LGTM, but not marking this approved until on tagged server. There seem to be other tests the latest server is breaking.

cretz avatar Sep 05 '24 14:09 cretz