cli icon indicating copy to clipboard operation
cli copied to clipboard

[Feature Request] Enable gRPC reflection

Open lorensr opened this issue 2 years ago • 3 comments

Enable reflection on frontend service during temporal server start-dev

lorensr avatar Dec 31 '22 06:12 lorensr

Is this not already enabled? I see it in server code at https://github.com/temporalio/temporal/blob/adf7c5471ec0e527bfcd3531f47bbd13604ba74e/service/frontend/service.go#L301 which our server here should use.

cretz avatar Jan 03 '23 18:01 cretz

All I'm seeing is the health service:

evans --reflection --port 7233

[email protected]:7233> show service
+---------+-------+--------------------+---------------------+
| SERVICE |  RPC  |    REQUEST TYPE    |    RESPONSE TYPE    |
+---------+-------+--------------------+---------------------+
| Health  | Check | HealthCheckRequest | HealthCheckResponse |
| Health  | Watch | HealthCheckRequest | HealthCheckResponse |
+---------+-------+--------------------+---------------------+

[email protected]:7233> show packages
+-------------------------+
|         PACKAGE         |
+-------------------------+
| grpc.health.v1          |
| grpc.reflection.v1alpha |
+-------------------------+

lorensr avatar Jan 15 '23 02:01 lorensr

Can you confirm our normal Temporal server enables reflection and this is just an issue w/ this embedded one?

cretz avatar Jan 16 '23 11:01 cretz

Seems like this works in the embedded server now:

❯ grpcurl -plaintext localhost:7233 list
grpc.health.v1.Health
grpc.reflection.v1.ServerReflection
grpc.reflection.v1alpha.ServerReflection
temporal.api.operatorservice.v1.OperatorService
temporal.api.workflowservice.v1.WorkflowService
temporal.server.api.adminservice.v1.AdminService

josh-berry avatar Aug 09 '24 21:08 josh-berry