cli icon indicating copy to clipboard operation
cli copied to clipboard

Published 20 hours ago • verified publisher icon temporalio

Batch rate limit

Open stephanos opened this issue 9 months ago • 1 comments

What was changed

Added support for passing --rps flag to batch operations.

ℹ️ FYI I've only added a single test for TerminateWorkflow, even though there are 3 batch APIs. Reason being that the API is the same and the only difference is the "operation". Let me know if I should add it to the others as well.

❓ Note sure why I'm seeing the CLA request on my PR.

Checklist

  1. Closes

  2. How was this tested: Added new tests.

  3. Any docs updates needed?

stephanos avatar May 06 '24 17:05 stephanos

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 06 '24 17:05 CLAassistant

Let's make sure this is in the next CLI release.

tlalfano avatar May 09 '24 16:05 tlalfano

@stephanos I think the cli-rewrite branch is dead, main becoming the new target branch for the last two weeks, you may want to merge in main instead... @cretz Can you confirm? I'm going to use your float changes for one of my flags, thanks for doing that!

antlai-temporal avatar May 13 '24 02:05 antlai-temporal