cli icon indicating copy to clipboard operation
cli copied to clipboard

[Feature Request] Prompt for confirmation by default for delete/terminate/cancel

Open lorensr opened this issue 2 years ago • 4 comments

Is your feature request related to a problem? Please describe.

User accidentally deleting a workflow.

Describe the solution you'd like

By default, prompt something like:

$ temporal workflow delete -w foo
Id: foo
Would you like to X this Workflow? Y/n

Pass -y to skip prompt

lorensr avatar Jul 19 '23 21:07 lorensr

we can add this also for consistency with batch operations such as temporal workflow terminate --query ..

Then users can disable the prompt entirely for default env with temporal env set default.yes true

feedmeapples avatar Jul 21 '23 18:07 feedmeapples

I don't think we want confirmation for termination / cancellation of a single workflow, it's reversible. I'm okay with adding it to delete.

bergundy avatar Jul 26 '23 20:07 bergundy

How do you reverse, by resetting to the last event before termination/cancellation? Wonder how many know that. I guess those that ask support will find out.

lorensr avatar Jul 27 '23 06:07 lorensr

I guess since reset will be in the UI for closed workflows, it will be much more discoverable.

lorensr avatar Jul 27 '23 06:07 lorensr